Skip to content

[python] - cpython - prev. version fallback - fix#907

Merged
samruddhikhandale merged 3 commits intodevcontainers:mainfrom
gauravsaini04:python_cpython_fallback_fix
Mar 13, 2024
Merged

[python] - cpython - prev. version fallback - fix#907
samruddhikhandale merged 3 commits intodevcontainers:mainfrom
gauravsaini04:python_cpython_fallback_fix

Conversation

@gauravsaini04
Copy link
Copy Markdown
Contributor

Feature name:

  • Python

Description:

This PR introduces the following functionality:

  • When the latest tag for cpython doesn't have a source binary released yet, then it will continue installing the previous working version for which a source binary will be available

Changelog:

  • Updated install.sh
  • Updated tests to validate that when a fake cpython version is tried to be downloaded with curl command thus representing trying to access a source binary which is not deployed yet, then will pick up the binary for the tag which will eventually work successfully.
  • Updated patch version in devcontainer-feature.json

Checklist:

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner March 12, 2024 16:02
Copy link
Copy Markdown
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one minor comment

Copy link
Copy Markdown
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one minor comment

Comment thread src/python/install.sh Outdated
Comment thread src/python/devcontainer-feature.json
Copy link
Copy Markdown
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👏

@samruddhikhandale samruddhikhandale merged commit 5ad3f6f into devcontainers:main Mar 13, 2024
@gauravsaini04 gauravsaini04 deleted the python_cpython_fallback_fix branch March 13, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants